vsapsai added a comment. As a proof of concept how ODR hash comparison can be used during deserialization, please see D124289 <https://reviews.llvm.org/D124289>. My point is to highlight the amount of reuse we gain from using ODR hash (I particularly enjoy the test case reuse). I agree the error messages aren't particularly useful yet and it will take some work to make code in `ASTReader::diagnoseOdrViolations` usable from parser. But I believe that should be doable.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124287/new/ https://reviews.llvm.org/D124287 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits