ChuanqiXu added a comment. In D123837#3461474 <https://reviews.llvm.org/D123837#3461474>, @iains wrote:
> thanks for multiple iterations! Thanks for the reviewing! > I think maybe you are using a too old clang-format? > it seems that clang-format >= llvm-14 removes spaces around module partition > colons ... so `A : Part`==>`A:Part` and `: Impl` => `:Impl`. > IMO this is the correct formatting (since it follows the examples in the > standard). > > Anyway, this is most likely the reason for the clang format fails on the CI. > > This now LGTM - but please fix the formatting in the test cases. Yeah... It looks like I did't set clang-format to the newest version. Thanks for reminding. I would do it when committing the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
