thakis added a comment.

Please add a clear comment to the new library's CMakeLists.txt file that 
explains when to put code there and when in clang/lib/Basic. (The patch 
description does say it, but the patch description is harder to find than a 
comment in the cmake file.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to