rovka added a comment.

I just have a couple of nits, I'll leave it to the clang devs to properly 
review this.



================
Comment at: clang/test/CMakeLists.txt:17
   LLVM_WITH_Z3
+  CLANG_BUILT_STANDALONE
   )
----------------
Nit: These seem to be sorted alphabetically.


================
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:17
+    # These tests are only relevant to developers working with the
+    # update_cc_test_checks.py tool they don't don't provide any coverage
+    # for any of the clang source code.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123967/new/

https://reviews.llvm.org/D123967

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to