nikic added a comment.

Please do not change names in the FFI API at least. It's okay to drop it 
entirely, but renaming is unnecessarily hostile for FFI APIs.



================
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:95
+#endif
+  Builder.populateModulePassManagerLegacy(MPM);
 }
----------------
This seems like an easy usage to replace?


================
Comment at: llvm/include/llvm-c/Transforms/PassManagerBuilder.h:72
+#ifdef __GNUC__
+__attribute__((deprecated("Migrate to new pass manager for optimization 
pipeline. This header will be removed in LLVM 16.")))
+#endif
----------------
Let's not promise any specific timeline. IMHO we should drop this as soon as 
there are no in-tree users anymore.


================
Comment at: llvm/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp:313
+    LLVMPassManagerBuilderPopulateModulePassManagerLegacy(passBuilder,
+                                                          modulePasses);
+
----------------
This also looks like an easy usage to remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124063/new/

https://reviews.llvm.org/D124063

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to