qiongsiwu1 added a comment. In D123498#3458357 <https://reviews.llvm.org/D123498#3458357>, @DavidSpickett wrote:
> Unless I'm missing an existing check, is it possible to check for the > existing files too? I guess not nicely because along with the resource > headers there are lots of internal headers, so we'd have to maintain some > list of "non resource" headers which means we've just created another thing > to maintain. This is a good point. Having such checks will be beneficial, but I concur that it is not easy to check for all the existing files given what we have now (the current way headers are organized etc) and I agree that we may end up maintaining more lists. Therefore I am keeping this patch in its current shape at this stage. I can come back and revisit once I find a clean way to check for the necessity of the header file. Maybe I can ask `cmake` to check for architecture/targets during configuration and select the headers automatically, but that is beyond the scope of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
