void added a comment. In D123544#3448046 <https://reviews.llvm.org/D123544#3448046>, @aaron.ballman wrote:
> In D123544#3446814 <https://reviews.llvm.org/D123544#3446814>, @void wrote: > >> Let me work on that. But otherwise are you okay with this patch? > > Yes, I'm okay with the direction of this patch. However, because this still > automatically randomizes some structure layouts once the user passes the > flag, I think the diagnostic above should perhaps land first unless there's > some strong reason not to. (To be honest, I probably should have insisted on > it in the first patch, but this one feels significantly more dangerous > because it involves function pointers specifically and is more of an > "automatic" feature than the first patch.) It was definitely an oversight on my part as well. This patch will be going in llvm 15, not 14, so there's probably not a huge rush to get this in first. I'll focus on the error and have a patch out soon-ish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
