beanz added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:1196
+
+ if (IsDXCMode()) {
+ // clang-dxc target is build from target_profile option.
----------------
nit: this can be an `else` for the `if` above
================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:39
+
+ VersionTuple MaxVer(6, MaxShaderModel6Minor);
+ switch (Kind) {
----------------
I don't think there is a good reason to verify max versions in the compiler.
This kind of code just makes more places we have to update when things move
forward.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122865/new/
https://reviews.llvm.org/D122865
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
