benshi001 marked an inline comment as done.
benshi001 added a comment.

In D123200#3444520 <https://reviews.llvm.org/D123200#3444520>, @MaskRay wrote:

> Initial support for a new target has a high standard. It needs to show decent 
> support, otherwise it may just invite fixups which may in the end waste 
> review resources.
> Showing that these files buildable is far from enough. You'd need to show 
> that the run-time tests actually work.

Could you please tell me more about `show that the run-time tests actually 
work` ? AVR is 8-bit MCU with any OS, so I just want some math functions in 
compiler-rt/lib/builtins, to avoid linking to libgcc.a.

I have checked that there are tests at `compiler-rt/test/builtins/Unit/arm`, 
and I guess them to be run on a ARM host. So I have to make a new directory 
`compiler-rt/test/builtins/Unit/avr` with some test cases, and promiss that 
they can run on an AVR board? (https://www.arduino.cc/en/hardware#boards-1)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123200/new/

https://reviews.llvm.org/D123200

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to