rsmith added a comment.

The patch description doesn't match the patch: we have `__remove_cv` in the 
description but `__remove_cv_qualifiers` in the patch. It seems unfortunate to 
me to use a long-term bad name for our trait to  work around a (likely) 
short-term problem with a specific version of libstdc++. Perhaps we could 
demote the `__remove_cv` keyword to a plain identifier if it's not followed by 
a `(` instead (we've done similar things for other trait keywords that have 
conflicted with libstdc++); would that be enough to resolve the incompatibility?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116203/new/

https://reviews.llvm.org/D116203

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to