aaron.ballman added a comment.

In D123074#3430705 <https://reviews.llvm.org/D123074#3430705>, 
@AaronSiddharthaMondal wrote:

> @aaron.ballman There may have been something wrong with the commit. On GitHub 
> it does not link to my user account. Would it be possible to change that?
> The github name is aaronmondal.

Sorry for the trouble -- the option to land with attribution takes `name 
<email@address>` form, not a GitHub username.

I can reland with different attribution, but that churns the git history and 
makes git blame harder for code archeology, so it's nice to avoid if possible. 
I think adding your secondary email address to your GitHub account should also 
address the issue 
(https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account).
 But if it doesn't and you'd still like the attribution changed, I can revert 
and recommit (probably tomorrow at this point, I'm just about done for the day 
today).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to