serge-sans-paille added inline comments.
================ Comment at: clang/test/Frontend/stack-usage-safestack.c:1 +/// Check that stack frame size warnings behave the same when safe stack is enabled + ---------------- I think this should be a bitcode-level test à la test/CodeGen/X86/warn-stack.ll Or at least it should use fixed-size integers so that the checked values are more explicit (a.k.a the test here works because of the triple that implies sizeof(int) == 4). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
