Ilod marked an inline comment as done. ================ Comment at: test/Driver/cl-options.c:283 @@ -282,3 +282,2 @@ // RUN: /nologo \ -// RUN: /Ob1 \ // RUN: /openmp- \ ---------------- hans wrote: > You're removing it from the ignored flags here, but I don't see any code > change or test for how clang-cl's supposed to handle it. What am I missing? Removing it from the ignored flags make if fallback to the generic /0 multi-param handling, in MSVCToolchain.cpp TranslateOptArg function. However I just checked that I forgot to forward the argument from the clang driver to cc1 in ConstructJob. Will add this (and a test for the driver) and submit a new patch.
http://reviews.llvm.org/D20647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
