hubert.reinterpretcast added inline comments.
================
Comment at: clang/include/clang/Sema/Weak.h:33
+ : alias(Alias), loc(Loc) {}
+ inline IdentifierInfo *getAlias() const { return alias; }
inline SourceLocation getLocation() const { return loc; }
----------------
hubert.reinterpretcast wrote:
> aaron.ballman wrote:
> > Would it be onerous to make the return type be `const IdentifierInfo *`
> > given that the function is `const`? (If it is, just ignore the suggestion
> > -- I love adding const correctness where we can get it basically for free.)
> It's not free but I can post an NFC patch to add the `const` through. On the
> chain of calls that `const` needs to be added to, the pointer eventually
> feeds a `DeclarationName` (which already takes `const IdentifierInfo *`).
https://reviews.llvm.org/D122261 has the NFC patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121927/new/
https://reviews.llvm.org/D121927
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
