saudi accepted this revision. saudi added a comment. This revision is now accepted and ready to land.
It is indeed much cleaner this way`, thanks! The tests are not anymore the same for `clang-cl` as for `clang`, but I agree what needs testing is the clang-cl specific behaviors, not having the same tests redone as a `clang-cl` flavor. ================ Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3 + +// REQUIRES: shell + ---------------- I was wondering whether it could be a concern that this test will be skipped on Windows systems, where `clang-cl` specific development would most likely occur. However I'm pretty sure it's ok, since this test is pretty simple and small, has little chances to break during most development iterations, and we would run the tests under linux at some point anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
