OikawaKirie added a comment. Herald added a project: All. Thanks, @keith.
I agree with @keith to commit this patch without using on-demand-parsing through cc1. As this patch has nothing to do with the target triple issue we found. In the current version, I use the PCH file to load the external TU. And it seems to work fine on my system and on the Windows CI. IMO, maybe we can just leave a FIXME or something else in the test case and commit this patch to fix the original problem we want to fix. (of course, re-submit to rerun the test case on Linux) What do you think? @steakhal CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
