haowei added a comment. We are seeing test failures after this patch is landed:
Clang :: SymbolGraph/global_record.c Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp : 'RUN: at line 2'; split-file /b/s/w/ir/x/w/llvm-llvm-project/clang/test/SymbolGraph/global_record.c /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp : 'RUN: at line 3'; sed -e "s@INPUT_DIR@/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp@g" /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/reference.output.json.in >> /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/reference.output.json : 'RUN: at line 5'; /b/s/w/ir/x/w/staging/llvm_build/bin/clang -extract-api -target arm64-apple-macosx /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/input.c -o /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/output.json | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck -allow-empty /b/s/w/ir/x/w/llvm-llvm-project/clang/test/SymbolGraph/global_record.c : 'RUN: at line 7'; sed -e "s@\"generator\": \"clang.*\"@\"generator\": \"clang\"@g" /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/output.json >> /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/output-normalized.json : 'RUN: at line 9'; diff /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/reference.output.json /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp/output-normalized.json -- Exit Code: 1 Command Output (stdout): -- 8c8 < "generator": "clang" --- > "generator": "Fuchsia clang version 15.0.0 (https://llvm.googlesource.com/a/llvm-project a597d6a780b184539f504392168b004bf392a135)" -- Failed builder task: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8819495289632137105/overview . Detailed test outputs: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8819495289632137105/test-results Could you fix the test please? If it takes a long time to fix, could you revert the change first please? I think you probably shouldn't simply use diff at L9 in clang/test/SymbolGraph/global_record.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
