kda added inline comments.
================
Comment at: clang/lib/CodeGen/CGClass.cpp:1872
// Ignore trivial destructors.
+ if (BaseClassDecl->hasTrivialDestructor()) {
----------------
vitalybuka wrote:
> kda wrote:
> > Maybe not "Ignore"?
> @kda I assume it's about inconsistent comment about?
>
@vitalybuka: exactly. This does not look like it is ignoring trivial
destructors anymore.
================
Comment at: compiler-rt/test/msan/dtor-base-access.cpp:36
+Derived *g;
+
----------------
vitalybuka wrote:
> kda wrote:
> > maybe in good faith '= nullptr'?
> according standard declarations like this are always zero initialized already
Okay. I was not aware of the standard. I am accustomed to making things
clear, because everyone may not be aware of the standard.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119300/new/
https://reviews.llvm.org/D119300
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
