rnk added a comment. Seems reasonable, this could use far more testing.
================ Comment at: clang/test/Lexer/ms-extensions.c:27 +#define INT128_MAX 170141183460469231731687303715884105727i128 +#define UINT128_MAX 0xffffffffffffffffffffffffffffffffui128 + ---------------- This seems like it could use more testing. Check for other `__int128` tests, and try adding a few of these literals to those tests with some basic arithmetic expressions. In a similar vein, I believe there are already bugs that lurk behind `__int128` non-type template parameters. It's worth setting up a few of those test cases. One of the main usages of the expr printer is to produce debug info for non-type template parameters. Do i128 suffixes come through there correctly now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121497/new/ https://reviews.llvm.org/D121497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
