kovdan01 marked an inline comment as done. kovdan01 added inline comments.
================ Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG ---------------- mehdi_amini wrote: > This is a private header (you're in the `lib` directory and not in the > `include` directory) > > Same for the SystemZ one above I believe. Makes sense, fixed, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
