aaron.ballman added a comment. In D121233#3371422 <https://reviews.llvm.org/D121233#3371422>, @sammccall wrote:
> Thanks Aaron, and my apologies for being easily frustrated. No worries at all! I always appreciate our discussions, even when we don't initially agree. > In D121233#3370992 <https://reviews.llvm.org/D121233#3370992>, @aaron.ballman > wrote: > >> 2. The layout of clang-tools-extra in terms of test directories is >> problematic and it'd sure be nice if someday someone moved the test >> directories under the individual tools instead of using a top-level test >> directory. > > I'd really like to enable this. > I think the blocker is mostly the amount of boilerplate needed to set up test > directories. > These required files are mostly boilerplate: > > - test/CMakeLists.txt (deps are meaningful, rest is boilerplate) > - test/lit.site.cfg.py.in > - test/lit.cfg.py > - test/Unit/lit.site.cfg.py.in (this patch puts these under unittest/ > instead, but either way) > - test/Unit/lit.cfg.py > > Creating 10 more copies of each of those seems a little irresponsible, > especially for tools that are "lightly maintained". So it's hard to say with > a straight face that restructuring them all is a good idea, and maybe this > motivated the original clang-tools-extra structure. > But if those files were generated/eliminated somehow, restructuring would be > very simple patches that didn't add more cruft to maintain. > > It's not obvious to me exactly how to do this (lit.* files affect both > discovery and configuration) but I'll dig into this more tomorrow. That's fair. It could be that we decide that clang-tools-extra is the dumping ground for lightly maintained one-off tools where it makes sense to share docs and tests, and other things that are expected to be actively maintained long-term (clang-tidy, clandg) should live at the top level of the monorepo as stand-alone tools. That may add more tension for where to add new projects though, so it may not be ideal either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121233/new/ https://reviews.llvm.org/D121233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
