junaire added a comment.

In D119609#3369816 <https://reviews.llvm.org/D119609#3369816>, @erichkeane 
wrote:

> The commit message isn't quite accurate, we're prohibiting it in ALL default 
> arguments.

Yeah, I just realize this issue after changing the message.

>>> I just realized that something is not very clear here. Should we prohibit 
>>> expression statements in all default arguments or just in lambda and 
>>> templates? I wonder how gcc folks think about it as well.
>
> The latest patch was to prohibit it ONLY in the lambda default parameters, 
> but I though the discussion on the GCC bug had the patch author show 
> preference for all cases.  Can you please ping the thread to see what they 
> plan to do so we can align?

OK, done. let's wait the feedback before we continue the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119609/new/

https://reviews.llvm.org/D119609

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to