aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/test/Headers/stdbool.c:2 +// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c11 -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C11 %s +// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c2x -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C2X %s + ---------------- tbaeder wrote: > aaron.ballman wrote: > > If you're playing along at home, `stdbool.cpp` tests the C++ behavior, so > > we don't need an additional RUN line here for that. > > > > However, I'd appreciate a RUN line that defines > > `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS` to demonstrate we don't emit the > > warning or the defines in that case. > I don't understand, both of the `RUN` lines are for C. > I don't understand, both of the RUN lines are for C. An earlier form of your patch broke the behavior in C++ and I didn't recall if the precommit CI pipeline caught the failure or not. So I thought "hmm, should we have a C++ RUN line here to catch that break or do we already have test coverage?" It turns out we have existing coverage, so I was reporting that so other reviewers (including drive-by reviews) knew we already thought about that. Thanks for adding the other RUN line for the macro definition! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
