ChuanqiXu added a comment.

In D121271#3369276 <https://reviews.llvm.org/D121271#3369276>, @iains wrote:

> I think you need to extend the test case (and possibly the code) to handle an 
> implementation partition as well, where the module is both interface and 
> implementation.

Yeah, this is the intention of `partb` (maybe I took a typo).

---

Also, I found all the CodeGen tests patch would better to depend D118352 
<https://reviews.llvm.org/D118352> otherwise @urnathan might need to rebase 
again or we need to unnecessary rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121271/new/

https://reviews.llvm.org/D121271

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to