sammccall added a comment.
Herald added a subscriber: ormris.

@hokein I talked about making some headers private, but realized that change 
really is unrelated, and would be confusing to mix in here.

This is awkward to review. I think the main things to check:

- whether the intended renames (see patch description) are correct
- the CMakeLists and lit.* configs: these are largely new (albeit cobbled 
together from other configs)

Going through the source file changes line-by-line is unlikely to be 
enlightening. Most likely errors is if I forgot to change something, which 
would be annoying but can be fixed forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to