ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:20 +/// +/// FIXME: Consider separating the models from the unchecked access analysis. +class UncheckedOptionalAccessModel ---------------- sgatev wrote: > ymandel wrote: > > Delete? > Why? I do think it makes sense to separate the model of optional types from > the analysis that tracks unsafe uses. I don't think we're in a place to do > the separation yet so that's why I added the FIXME. Sorry, I misread it. Fine as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121197/new/ https://reviews.llvm.org/D121197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
