SAtacker added a comment.

In D120331#3354021 <https://reviews.llvm.org/D120331#3354021>, @JonasToth wrote:

> LGTM, but please adjust the naming nit to a better name.

Thanks for the review again. 
Will rename the `group` to `config_group` as you suggested and I feel that too.

> do you have commit rights? Otherwise someone (e.g. me) could commit on your 
> behalf, of course with a remark that its your contribution :)
>
> (btw. go ahead and ping me again, I am busy with too many things right now :/)

I don't have the access to land this commit into the llvm-project. Until then I 
shall trust this wonderful process :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120331/new/

https://reviews.llvm.org/D120331

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to