jchlanda added a comment. Herald added a project: All. In D117887#3352079 <https://reviews.llvm.org/D117887#3352079>, @tra wrote:
> In D117887#3351257 <https://reviews.llvm.org/D117887#3351257>, @jchlanda > wrote: > >> @tra thank you for landing the patches, it seems that the clang part >> (builtin declarations and tests) have been dropped, only `llvm` dir changes >> made it through. Is there any way I could fix it (same goes for the other >> two patches in this stack)? > > Somehow `arc export | git apply` didn't pick clang changes when I was > transferring the patch from the phabricator. I'll re-fetch the patches and > will land the missing pieces shortly. > > I'm not sure how the you've submitted the patch to phabricator. In general, > it works best when the patch is supplied as a gic commit diff, with the > author metadata, etc. > Or via `arc diff`. See for the details. > https://llvm.org/docs/Phabricator.html#phabricator-reviews I went with the web interface as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface with `git diff -U999999 ...` didn't want to bite the bullet of `arc`, hoping that github PRs will soon be a thing. All working now, thank you for resolving that so quickly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117887/new/ https://reviews.llvm.org/D117887 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
