keith added inline comments.
================
Comment at: llvm/utils/lit/lit/TestRunner.py:1124
+ if kIsWindows:
+ fs_root = 'C:\\'
+ substitutions.extend([
----------------
probinson wrote:
> rnk wrote:
> > It is pretty common to run the LLVM test suite on secondary drives,
> > especially on buildbot VMs, to separate build disk usage from the root
> > partition. Can we have two separators, `${srcroot}` and `${tmproot}` that
> > expand to the drive letter of the source and temp path base? That seems
> > like it would be general and implementable.
> +1. I don't even do builds on C: drive, on one of my machines.
Updated, I kept the `fs` prefixing thinking that `srcroot` and `tmproot` might
be too confusable as an alternative to `%t` and friends, let me know what you
think!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111457/new/
https://reviews.llvm.org/D111457
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
