phyBrackets added inline comments.

================
Comment at: clang/test/Analysis/bstring.c:310
 
-  clang_analyzer_eval(p == &dst[4]); // expected-warning{{TRUE}}
+  clang_analyzer_eval(p == &dst[4]); // no-warning (above is fatal)
 }
----------------
NoQ wrote:
> Hmm, given that your change suppresses some existing tests, maybe disable 
> your checker on this file and copy the updated tests to a new file that would 
> have the checker enabled?
I don't know how will it affect that but still that's an exception and from 
these exceptions test cases, we are updated about how it gonna fail on some 
tests cases and try to work on those exceptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120489/new/

https://reviews.llvm.org/D120489

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to