dblaikie added inline comments.
================ Comment at: clang/test/Modules/inconsist-export-template.cpp:1-2 +// RUN: %clang_cc1 -std=c++20 %s -fsyntax-only -verify +// expected-no-diagnostics +export module m; ---------------- This test doesn't appear to test anything - it verifies that this file produces no diagnostics, but not that it has any other/particular behavior. Should this be testing codegen to verify that the correct linkage was used on the resulting IR functions? Are there other ways of observing the particular language-level linkage of the entities to confirm it's as expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
