erichkeane accepted this revision. erichkeane added a comment. Just did a pass through, nothing suspicious, I think this looks good.
Mild preference to merge 2 or 3 diagnostics based on how similar they all are, but that can be done without further review, or as a separate commit (or not at all, if no one else cares). ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2327 "initializer for variable %0 with type %1 contains multiple expressions">; +def err_auto_expr_init_multiple_expressions : Error< + "initializer for functional-style cast to %0 contains multiple expressions">; ---------------- Mild preference to merge at least 2 of these 3 diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
