nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed.
One final note: many of the methods I've suggested produce a `SourceRange`, and we'll need to convert it to `Range`. I think it should be fine to convert the begin and end `SourceLocation`s separately using `getRangeForSourceLocation()`, which will give you two `Range`s B and E, sanity-check that B <= E, and take (B.begin(), E.end()) as the final range. That's all I've got for now. I may have follow-up suggestions about code organization / reuse (e.g. factoring out the modifier-setting code), but that will be easier to reason about once the changes discussed so far have been made. Thanks again for your efforts on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
