owenpan added inline comments.
================
Comment at: clang/lib/Format/FormatToken.h:382
+ }
+ bool typeIsFinalized() const { return TypeIsFinalized; }
----------------
HazardyKnusperkeks wrote:
> owenpan wrote:
> > I thought you didn't like using the same [[
> > https://reviews.llvm.org/D116316#inline-1112220 | name ]] for both a
> > variable and function. :)
> Naming a getter after the member you get should (nearly) always be done.
>
> What I still stand to is having a local variable named after the function it
> is initialized from (this alone is fine), but then still calling the function
> in a loop. `IsPrecededByCommentOrPPDirective` is not the same as
> `precededByCommentOrPPDirective()` since the function relies on the changing
> token. I still find that very confusing, but for now I know that this code
> does not affect me while debugging, because I don't use the option.
Point taken.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120511/new/
https://reviews.llvm.org/D120511
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
