erichkeane added a comment. In D120266#3345649 <https://reviews.llvm.org/D120266#3345649>, @ibookstein wrote:
> Ah, I saw your comment just now, good thing I didn't continue down that > plain-alias-name route then! > The change now satisfies that requirement in a way that binding against the > alias name indeed would not: TU1 will have the callsite in `caller` bind > against `foo.ifunc`, which is not a symbol that TU2 defines. Ah! I'm glad you did too! Thanks for the patch. I think this works for me, I definitely like the 'upgrade' better than the 'downgrade'. Can you please make sure there is an 'upgrade' path test in all of the configurations in the tests before committing? That is, something like: dispatch def specific def call in all orders? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120266/new/ https://reviews.llvm.org/D120266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
