yurai007 added a comment.

In D120334#3340639 <https://reviews.llvm.org/D120334#3340639>, @cor3ntin wrote:

> I like this approach. it seems a lot easier to maintain as people don't have 
> to remember to use LangOptionsBase to not degrade performance

I like it either but we need to be careful about LangOptions lifetime as my 
previous comment shows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to