shangwuyao added a comment.
In D120366#3344221 <https://reviews.llvm.org/D120366#3344221>, @jlebar wrote:
> - What's different in this patch vs the previous one?
Previous patch broke at two different post-commit build configurations. The
generated SPIR-V are:
define hidden spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef
%output.coerce) #0 {
define spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef %0) #0 {
And the original test:
// CHECK: define spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef
%output.coerce)
Changed that to below so that it could handle those two build configurations
correctly.
// CHECK: define
// CHECK-SAME: spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef
(The previous reverted patch could have been reopened so that the change is
more clear, but didn't know such option exist until recently.)
> - *Disabled a hip test on Windows that's breaking on head.* Can you clarify:
> Is this test broken at HEAD, or does it break with your patch?
>
> If it's broken at HEAD, then it should be disabled in a separate patch.
>
> If it breaks with your patch, can you explain why it should be disabled
> rather than fixed?
It is broken at HEAD, will add another patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120366/new/
https://reviews.llvm.org/D120366
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
