pengfei added inline comments.

================
Comment at: clang/lib/Headers/avx512fintrin.h:5944
+      (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C),     
\
+      (unsigned char)(imm), (__mmask16)-1))
+
----------------
craig.topper wrote:
> Why do we need to change the type on `imm` here? The builtin takes an int, 
> and the enum you created defaults to int. Is this so we truncate ~ to 8-bits?
Yes. By the way, ICC and MSVC don't error out for it. 
https://godbolt.org/z/s1bG1sq9q


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120307/new/

https://reviews.llvm.org/D120307

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to