melver added a comment.

Adding a new IR attribute comes with a whole slew of other required changes. 
Please see https://reviews.llvm.org/D102772 for an example.

In addition, please update the patch description to explain what the problem is 
exactly (remove the old kernel-specific problem, because it's only a 
distraction). In particular, what current no_sanitize does (because it does 
something for "bounds checking), and what is missing. Introducing a new IR 
attribute needs to be properly justified, so if you can explain why this can't 
be solved another way would also be useful (something like .. the local-bounds 
code generation happens in the middleend and not frontend unlike some other 
UBSAN checks).

Also, you need to add some IR tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119816/new/

https://reviews.llvm.org/D119816

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to