curdeius marked an inline comment as done.
curdeius added inline comments.

================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1951
+            // FIXME: Maybe we should handle identifiers ending with "_cast",
+            // e.g. bit_cast?
+            return true;
----------------
lichray wrote:
> Very unlikely `bit_cast` gives you something callable; `any_cast` may. I 
> think keywords are ok for now, and cheap. Others may need a different 
> strategy.
Indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120140/new/

https://reviews.llvm.org/D120140

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to