urnathan added inline comments.
================ Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'import' keyword. - /// \param Path The module access path. + /// \param NamePath The module toplevel name as an access path. + /// \param Partition The module partition name as an access path. ---------------- Is `NamePath` really a better name? You've not consistently changed all `Path`'s to this, and it doesn;t strike me as particularly mnemonic. ================ Comment at: clang/lib/Parse/Parser.cpp:2394 /// Parse a module import declaration. This is essentially the same for -/// Objective-C and the C++ Modules TS, except for the leading '@' (in ObjC) +/// Objective-C and the C++20/Modules TS, except for the leading '@' (in ObjC) /// and the trailing optional attributes (in C++). ---------------- perhaps now we should just remove modules-ts references as drive-by cleanups? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
