thakis added a comment. > Oh, I added a NFC fix previously in > https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3. > I think it should be reverted too? I am going to revert it.
I did that in 5d110ed4cd4 <https://reviews.llvm.org/rG5d110ed4cd475b9b70bc9faecfe4f0767740c5a3>. See this comment (and above) https://github.com/llvm/llvm-project/blob/main/clang/test/Misc/warning-flags.c#L19 for why that change only papered over an actual problem :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
