Anastasia added a comment. In D118605#3313859 <https://reviews.llvm.org/D118605#3313859>, @azabaznov wrote:
>> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >> we need this check to preserve the existing behavior indeed. > > Thanks. The other test is `SemaOpenCL/clang-builtin-version.cl`. > >> But it might be worth asking someone outside of the OpenCL community whether >> it's desirable to use the LanguageID enum in this way. > > I personally think this looks good now, for OpenCL in particularly, as it > became version-agnostic (except for DSE). But we still are querying language > options only, and we expect language options for generic AS, pipes and DSE to > be immutable at this point. Note that this `LanguageID` is intended for Builtins use because there are other `LanguageID`s used elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
