ABataev added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807
+ } else if (AtomicKind == OMPC_compare_capture) {
+ // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore
+ // code gen.
+ unsigned DiagID = Diags.getCustomDiagID(
+ DiagnosticsEngine::Error,
+ "atomic compare capture is not supported for now");
+ Diag(AtomicKindLoc, DiagID);
----------------
Better to build a node and emit error in codegen. Without it you're unable to
create ast-print/dump tests, test for serialization/deserialization etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116261/new/
https://reviews.llvm.org/D116261
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
