lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land.
Ah, I see. Please can you also remove the `CmdArgs` parameter from `arm::getARMTargetFeatures` when you commit this? This would be useful, along with a comment at the top of `getTargetFeatures` to discourage targets adding to or using `CmdArgs` in their `get<Target>TargetFeatures` functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
