mstorsjo added a comment.

To pick up the thread here again, `[[no_unique_address]]` is done and settled 
in MSVC, with the slightly surprising semantics: `[[no_unique_address]]` is 
accepted, without any warning (in C++20 mode), but it has no effect. (This, not 
related to LLVM, but because they had shipped it in earlier versions without 
having an effect, and changing that later would break things.) 
`[[msvc::no_unique_address]]` does have an effect though. See 
https://github.com/microsoft/STL/issues/1364#issuecomment-1034167093 for a more 
authoritative source on that.

So, separately from implementing `[[msvc::no_unique_address]]`, I think we also 
should also silence the current warning about unknown attribute for the 
standard `[[no_unique_address]]`, to match MSVC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110485/new/

https://reviews.llvm.org/D110485

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to