As for the original change proposed: My guiding principle would be "do whatever std::vector does". (& that's what I did when implementing GDB pretty printers for SmallVector/SmallString/ArrayRef, etc... )
An aside: We generally don't do time limited reviews like this. Either something needs review because you're not sure about it, or it doesn't. It sounds like the feedback you were looking for probably would've been fine a post-commit review feedback just as easily & perhaps might've been a better option. (while in this case it was fine - it's sort of a community habit/standards thing - we don't want to create the idea that lack of feedback is consent/approval in the review process) On Sun, Jun 12, 2016 at 7:01 PM, Mike Spertus via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mspertus closed this revision. > mspertus added a comment. > > revision 272525 > > > http://reviews.llvm.org/D21256 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
