aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D118104#3297315 <https://reviews.llvm.org/D118104#3297315>, @LegalizeAdulthood wrote: > In D118104#3296467 <https://reviews.llvm.org/D118104#3296467>, > @salman-javed-nz wrote: > >> Anyway, I don't want what was a drive-by comment by me baloon into a lot of >> extra work for the author, so I will not push for it, unless others really >> want it. > > I think it's reasonable to accept this change and have the tests added as a > follow-up change. Normally I'd be opposed to this, but given the testing difficulties with this tool are not new and this patch doesn't make them substantially worse, I think it's fine to land as-is and address testing in a follow-up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
