sammccall added inline comments.
================ Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:101 // and "x" will be treated as the same header when deleting #includes. - llvm::StringMap<llvm::SmallVector<Include, 1>> ExistingIncludes; + llvm::StringMap<std::list<Include>> ExistingIncludes; ---------------- May be worth a comment here that std::list is used for pointer stability, since it looks a little odd at first glance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
