kadircet added inline comments.
================
Comment at: clang/unittests/Lex/LexerTest.cpp:654
+ while (!L.LexFromRawLexer(T)) {
+ ASSERT_TRUE(!ToksView.empty());
+ EXPECT_EQ(T.getKind(), ToksView.front().getKind());
----------------
probinson wrote:
> @kadircet @sammccall It turns out this while loop is zero-trip; the test
> assertions in the body are never executed. Replace it with `assert(false);`
> and the test doesn't crash.
>
> That means `ToksView` is empty from the start. This is probably not what you
> wanted?
>
> In other words, the test does not exercise the patch. This is pretty
> serious. It needs to be fixed or reverted.
thanks! the discrepancy was actually having tokens in one but not the other,
hence tests were failing initially but after the fix the tests passed (by
making both lexing modes return none) so it skipped my attention. sending out a
fix now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118471/new/
https://reviews.llvm.org/D118471
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
